Add new system status command#118
Merged
katiewasnothere merged 1 commit intoapple:mainfrom Jun 10, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Consider changing this wording to
Suggested change
| print("apiserver is not running") | |
| print("apiserver is not registered with launchd") |
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion! It is definitely more precise than my wording.
Updated it to "apiserver is not running and not registered with launchd", as I think end users might not know what "registered with launchd" means.
Contributor
|
Thanks for the change! :) |
adityaramani
requested changes
Jun 10, 2025
Contributor
adityaramani
left a comment
adityaramani
left a comment
There was a problem hiding this comment.
Thanks for the PR! Just had a couple minor comments
Container services can be started and stopped using the `system start` and `system stop` commands. But there is no straightforward way for users to check if the services were already started. This commit adds a new `system status` command that shows wether the container services are running or not. The command only checks the status of the apiserver for now, but it could be expanded in the future to show more details.
adityaramani
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Container services can be started and stopped using the
system startandsystem stopcommands. But there is no straightforward way for users to check if the services were already started.This PR adds a new
system statuscommand that shows wether the container services are running or not.The command only checks the status of the apiserver for now, but it could be expanded in the future to show more details.
Fixes #117.