Assigns default nameserver in sandbox service.#276
Merged
jglogan merged 1 commit intoapple:mainfrom Jul 1, 2025
Merged
Conversation
Contributor
jglogan
commented
Jun 30, 2025
- Closes Network issue occurs when container build process installs pip packages #148.
- Storing the default nameserver in the bundle config means that DNS won't work if the container stops and then restarts later when the subnet address has changed.
* Closes apple#148. * Storing the default nameserver in the bundle config means that DNS won't work if the container stops and then restarts later when the subnet address has changed.
crosbymichael
approved these changes
Jul 1, 2025
Contributor
crosbymichael
left a comment
There was a problem hiding this comment.
This works for our current implementation but adding this note for future us; assuming the gateway is the name server could cause a bug later on. We should probably look at making this more explicit within the network services to be more robust.
Contributor
Author
|
pol> assuming the Yep, this definitely assumes a vmnet network. For our future us, one possibility is that the attachment descriptor returned by the network helper could include a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.