Skip to content

fix(ext/crypto): ecdh spki key import/export roundtrip#16152

Merged
littledivy merged 1 commit intodenoland:mainfrom
panva:fix-15523
Oct 4, 2022
Merged

fix(ext/crypto): ecdh spki key import/export roundtrip#16152
littledivy merged 1 commit intodenoland:mainfrom
panva:fix-15523

Conversation

@panva
Copy link
Contributor

@panva panva commented Oct 4, 2022

This change removes the use of OID 1.3.132.1.12 (id-ecDH) in ECDH spki export.

  • it is not interoperable with other implementations
  • it cannot be imported by Deno's own implementation

closes #15523

@panva
Copy link
Contributor Author

panva commented Oct 4, 2022

cc @littledivy

@panva panva changed the title fix(ext/crypto): ecdh spki key import/export rountrip fix(ext/crypto): ecdh spki key import/export roundtrip Oct 4, 2022
@panva panva mentioned this pull request Oct 4, 2022
Merged
@littledivy littledivy merged commit aa710aa into denoland:main Oct 4, 2022
littledivy pushed a commit that referenced this pull request Oct 4, 2022
@panva
fix(ext/crypto): interoperable import/export (#16153)
0d042d8 
This PR updates RSA key import/export to a state which is interoperable
with other implementations.

For RSA the only OID in and out is `rsaEncryption`.
For EC the only OID in and out is `id-ecpublickey` (fixed in #16152).

see w3c/webcrypto#307 (comment)
see w3c/webcrypto#307
see w3c/webcrypto#305
see nodejs/node#42816
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@littledivy littledivy littledivy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ECDH P-256: Exporting public key to 'spki' format produces an invalid result

2 participants

@panva @littledivy