docs: add bind-recursive mount option#4606
Merged
thaJeztah merged 1 commit intodocker:masterfrom Nov 14, 2023
Merged
Conversation
Follow-up to PR 4316 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4606 +/- ##
==========================================
- Coverage 59.71% 59.70% -0.01%
==========================================
Files 288 286 -2
Lines 24858 24855 -3
==========================================
- Hits 14843 14839 -4
Misses 9128 9128
- Partials 887 888 +1 |
Member
|
/cc @dvdksn ptal (let me know if you want to do a zoom call to walk through these options!) |
dvdksn
approved these changes
Nov 14, 2023
Contributor
dvdksn
left a comment
dvdksn
left a comment
There was a problem hiding this comment.
Thanks @AkihiroSuda - these changes LGTM. I will make a follow-up with changes to the bind mount documentation in docker/docs (https://docs.docker.com/storage/bind-mounts/)
This was referenced Nov 14, 2023
thaJeztah
reviewed
Nov 22, 2023
Comment on lines
+445
to
+448
| <li><<tt>enabled</tt>, <tt>true</tt> or <tt>1</tt>: Enables recursive bind-mount. | ||
| Read-only mounts are made recursively read-only if kernel is v5.12 or later. | ||
| Otherwise they are not made recursively read-only.</li> | ||
| <li><<tt>disabled</tt>, <tt>false</tt> or <tt>0</tt>: Disables recursive bind-mount.</li> |
Member
There was a problem hiding this comment.
Opened a PR for discussion to remove the boolean variants (motivation outlined in that PR);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to
bind-recursive=<bool|string>and deprecatebind-nonrecursive=<bool>#4316