cli/command/image: fix TestNewSaveCommandSuccess to actually test#5520
Merged
thaJeztah merged 1 commit intodocker:masterfrom Oct 8, 2024
Merged
Conversation
This test was added in [moby@b2551c6] as part of a larger PR that implemented unit tests in various packages. In this specific test, it looks like the `imageSaveFunc` that's defined in the test-table was forgotten to be wired up, causing all tests to effectively be skipped. This patch wires up the function so that it's used in the test. [moby@b2551c6]: moby/moby@b2551c6 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
11 tasks
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5520 +/- ##
=======================================
Coverage 60.58% 60.58%
=======================================
Files 345 345
Lines 23456 23456
=======================================
Hits 14211 14211
Misses 8273 8273
Partials 972 972 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was added in moby@b2551c6 as part of a larger PR that implemented unit tests in various packages. In this specific test, it looks like the
imageSaveFuncthat's defined in the test-table was forgotten to be wired up, causing all tests to effectively be skipped.This patch wires up the function so that it's used in the test.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)