completion: fix / add completion for service names and node-names

[thaJeztah]

• fixes [28.0.0] bash autocompletion works different #5847

completion: use service names, and support DOCKER_COMPLETION_SHOW_SERVICE_IDS

Change completion for services to use names by default, and bring back
support for the DOCKER_COMPLETION_SHOW_SERVICE_IDS env-var

cli/contrib/completion/bash/docker

Lines 41 to 43 in f9ced58

	# DOCKER_COMPLETION_SHOW_SERVICE_IDS
	# "no" - Show names only (default)
	# "yes" - Show names and ids

Before this patch:

docker service ps
c9vrp2pwni9gx5ghat20rjpcy  hmthf0tqws9xpmd87ok7diqly

With this patch:

docker service ps<TAB>
databaseservice  webservice

export DOCKER_COMPLETION_SHOW_SERVICE_IDS=yes
docker service ps<TAB>
c9vrp2pwni9gx5ghat20rjpcy  databaseservice            hmthf0tqws9xpmd87ok7diqly  webservice

completion: add completion for node names

Change completion for nodes to use names by default, and bring back
support for the DOCKER_COMPLETION_SHOW_NODE_IDS env-var

cli/contrib/completion/bash/docker

Line 38 in f9ced58

# DOCKER_COMPLETION_SHOW_NODE_IDS

With this patch:

docker node ps <tab>
docker-desktop            self

export DOCKER_COMPLETION_SHOW_NODE_IDS=yes
docker node ps <TAB>
docker-desktop             qyeriqk20al6hy4y869d08ff5  self

completion: add completion for docker node flags

With this patch:

docker node update --role
manager  worker

docker node update --availability
active  drain   pause

completion: add completion for docker service flags

Not all flags have completions yet, and for those that don't have completion,
we disable completion to prevent it completing with filenames.

- Human readable description for the release notes

Fix shell completion suggesting IDs instead of names for services and nodes

- A picture of a cute animal (not mandatory but encouraged)

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 64.84375% with 45 lines in your changes missing coverage. Please review.

Project coverage is 58.81%. Comparing base (f9ced58) to head (8f55738).
Report is 13 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #5848    +/-   ##
========================================
  Coverage   58.81%   58.81%            
========================================
  Files         349      350     +1     
  Lines       29556    29676   +120     
========================================
+ Hits        17382    17455    +73     
- Misses      11189    11236    +47     
  Partials      985      985            

[vvoland]

LGTM

[vvoland]

Suggested change

	ValidArgsFunction: func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
	return completeNodeNames(dockerCli)(cmd, args, toComplete)
	ValidArgsFunction: completeNodeNames(dockerCli)

nit

[thaJeztah]

Doh! Good call; wouldn't surprise me if we did the same in other places (sometimes the closures trip me up for sure!)