Merged
Conversation
Benehiko
added
impact/changelog
impact/deprecation
kind/refactor
This patch deprecates exported system commands and moves the implementation details to an unexported function. Commands that are affected include: - system.NewVersionCommand - system.NewInfoCommand - system.NewSystemCommand - system.NewEventsCommand - system.NewInspectCommand Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
Benehiko
force-pushed
the
commands/system
branch
from
53ceedd to
cfb8cb9
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR deprecates exported system command constructors in the Docker CLI by moving them to unexported implementations while maintaining backward compatibility through wrapper functions.
Key changes:
- Adds deprecation warnings to exported command constructor functions
- Creates new unexported command constructors with the actual implementation
- Updates internal usage to use the new unexported functions
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cli/command/system/version.go | Deprecates NewVersionCommand and adds newVersionCommand with implementation |
| cli/command/system/info.go | Deprecates NewInfoCommand and adds newInfoCommand with implementation |
| cli/command/system/events.go | Deprecates NewEventsCommand and adds newEventsCommand with implementation |
| cli/command/system/inspect.go | Deprecates NewInspectCommand and adds newInspectCommand with implementation |
| cli/command/system/cmd.go | Deprecates NewSystemCommand and adds newSystemCommand with implementation |
| cli/command/commands/commands.go | Adds nolint directives for deprecated function usage |
| cli/command/system/*_test.go | Updates test files to use new unexported command constructors |
| cli/command/system/completion_test.go | Updates completion test to use unexported function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch deprecates exported system commands and moves the implementation details to an unexported function.
Commands that are affected include:
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)