Skip to content

chore: bump node to v22.16.0 (main)#47217

Merged
jkleinsc merged 11 commits intomainfrom
roller/node/main
Jun 2, 2025
Merged

chore: bump node to v22.16.0 (main)#47217
jkleinsc merged 11 commits intomainfrom
roller/node/main

Conversation

@electron-roller
Copy link
Contributor

Updating Node.js to v22.16.0.

See all changes in v22.15.1..v22.16.0

Notes: Updated Node.js to v22.16.0.

@electron-roller electron-roller bot requested a review from a team as a code owner May 22, 2025 13:00
@electron-roller electron-roller bot added no-backport semver/patch backwards-compatible bug fixes labels May 22, 2025
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label May 22, 2025
@codebytere codebytere self-assigned this May 22, 2025
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label May 23, 2025
@codebytere codebytere requested a review from a team as a code owner May 23, 2025 18:41
@codebytere
Copy link
Member

codebytere commented May 26, 2025

Two failing tests

nodejs/node#57171

parallel/test-sqlite-backup

not ok 2577 parallel/test-sqlite-backup
  ---
  duration_ms: 808.00200
  severity: fail
  exitcode: 1
  stack: |-
    Test failure: 'database backup fails when dest file is not writable'
    Location: test/parallel/test-sqlite-backup.mjs:182:1
    AssertionError [ERR_ASSERTION]: Missing expected rejection.
        at async TestContext.<anonymous> (file:///__w/electron/electron/src/third_party/electron_node/test/parallel/test-sqlite-backup.mjs:188:3)
        at async Test.run (node:internal/test_runner/test:1054:7)
        at async Test.processPendingSubtests (node:internal/test_runner/test:744:7) {
      generatedMessage: false,
      code: 'ERR_ASSERTION',
      actual: undefined,
      expected: [Object],
      operator: 'rejects'
    }
    
    (node:41930) ExperimentalWarning: SQLite is an experimental feature and might change at any time
    (Use `electron --trace-warnings ...` to show where the warning was created)
  ...

and

nodejs/node#56253

parallel/test-config-file

not ok 575 parallel/test-config-file
  ---
  duration_ms: 8333.91000
  severity: fail
  exitcode: 1
  stack: |-
    Test failure: 'should throw an error when the file is non readable'
    Location: test/parallel/test-config-file.js:339:1
    AssertionError [ERR_ASSERTION]: The input did not match the regular expression /Cannot read configuration from node\.config\.json: permission denied/. Input:
    
    ''
    
        at TestContext.<anonymous> (/__w/electron/electron/src/third_party/electron_node/test/parallel/test-config-file.js:348:3)
        at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
        at async Test.run (node:internal/test_runner/test:1054:7)
        at async Test.processPendingSubtests (node:internal/test_runner/test:744:7) {
      generatedMessage: true,
      code: 'ERR_ASSERTION',
      actual: '',
      expected: /Cannot read configuration from node\.config\.json: permission denied/,
      operator: 'match'
    }
    
  ..

Weirdly, I can't get these to fail locally on Linux x64, despite them failing extremely consistently in CI.

@codebytere codebytere requested a review from a team as a code owner May 29, 2025 08:28
@codebytere codebytere force-pushed the roller/node/main branch 3 times, most recently from ad6834b to b47b208 Compare May 29, 2025 09:05
@jkleinsc jkleinsc merged commit 82a59d9 into main Jun 2, 2025
100 of 101 checks passed
@jkleinsc jkleinsc deleted the roller/node/main branch June 2, 2025 21:30
@release-clerk
Copy link

release-clerk bot commented Jun 2, 2025

Release Notes Persisted

Updated Node.js to v22.16.0.

@jkleinsc jkleinsc mentioned this pull request Jun 3, 2025
3 tasks
kigh-ota pushed a commit to kigh-ota/electron that referenced this pull request Sep 30, 2025
* chore: bump node in DEPS to v22.16.0

* crypto: remove BoringSSL dh-primes addition

nodejs/node#57023

* tools: enable linter in test/fixtures/test\-runner/output

nodejs/node#57698

* src: improve thread safety of TaskQueue

nodejs/node#57910

* buffer: define global v8::CFunction objects as const

nodejs/node#57676

* src: disable abseil deadlock detection

nodejs/node#57582

* zlib: fix pointer alignment

nodejs/node#57727

* chore: fixup patch indices

* src: set default config as node.config.json

nodejs/node#57171

* src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>

nodejs/node#57578

* test: disable chmod tests failing in Docker

nodejs/node#58326

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-backport semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants