Add RedundantNullCheck bug pattern.#5253
Merged
copybara-service[bot] merged 1 commit intomasterfrom Sep 26, 2025
Merged
Conversation
Closes #5107. A null check is redundant if it is performed on a variable or method call that is known to be non-null within a `@NullMarked` scope. Within a `@NullMarked` scope, types are non-null by default unless explicitly annotated with `@Nullable`. Therefore, checking a variable or method return value (that isn't `@Nullable`) for nullness is unnecessary, as it should never be null. Example: ```java import org.jspecify.annotations.NullMarked; import org.jspecify.annotations.Nullable; @NullMarked class MyClass { void process(String definitelyNonNull) { // BUG: Diagnostic contains: RedundantNullCheck if (definitelyNonNull == null) { System.out.println("This will never happen"); } // ... } String getString() { return "hello"; } @nullable String getNullableString() { return null; } void anotherMethod() { String s = getString(); // BUG: Diagnostic contains: RedundantNullCheck if (s == null) { // s is known to be non-null because getString() is not @nullable // and we are in a @NullMarked scope. System.out.println("Redundant check"); } String nullableStr = getNullableString(); if (nullableStr == null) { // This check is NOT redundant System.out.println("Nullable string might be null"); } } } ``` This check helps to clean up code and reduce clutter by removing unnecessary null checks, making the code easier to read and maintain. It also reinforces the contract provided by `@NullMarked` and `@Nullable` annotations. Fixes #5121 COPYBARA_INTEGRATE_REVIEW=#5121 from bdragan:5107-redundant_null_check f935970 PiperOrigin-RevId: 811924542
b4db300 to
a12903a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add RedundantNullCheck bug pattern.
Closes #5107.
A null check is redundant if it is performed on a variable or method call that is known to be non-null within a
@NullMarkedscope.Within a
@NullMarkedscope, types are non-null by default unless explicitly annotated with@Nullable.Therefore, checking a variable or method return value (that isn't
@Nullable) for nullness is unnecessary, as it should never be null.Example:
This check helps to clean up code and reduce clutter by removing unnecessary null checks, making the code easier to read and maintain.
It also reinforces the contract provided by
@NullMarkedand@Nullableannotations.Fixes #5121
FUTURE_COPYBARA_INTEGRATE_REVIEW=#5121 from bdragan:5107-redundant_null_check f935970