fix: Notes overflow in List's grid view#11670
Merged
cdrini merged 1 commit intointernetarchive:masterfrom Jan 30, 2026
Merged
Conversation
…k notes * Replace footer with a styled div for better presentation of book notes * Add new CSS class for list book notes to improve layout and readability * Define line-height for short snippets to ensure consistent typography
cdrini
approved these changes
Jan 30, 2026
Collaborator
There was a problem hiding this comment.
It's still a bit funky looking (eg) ; I wonder if we might want to hide the note entirely and have it be in some sort of tooltip. But what we have here is way better than what we have currently, so lgtm! Worked on testing.
cdrini
reviewed
Jan 30, 2026
| } | ||
| } | ||
|
|
||
| .list-books__note { |
Collaborator
There was a problem hiding this comment.
Ah I was too hasty in my testing. This affects the quote even when not in grid mode. We'll likely want to move this to static/css/components/search-result-item.less and only apply if the parent is in grid view.
This was referenced Jan 30, 2026
Collaborator
Author
|
@cdrini Thanks for all the testing as I seem to have overlooked some scenarios in my tests. 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11174
Fixes text overflow.
Technical
<div>around notes content which is limited to six lines max. Clamping happens via CSS.This PR is similar to #11522 but with two differences:
Testing
Screenshot
Stakeholders
@cdrini