Merged
Conversation
RayBB
changed the title
RayBB
added
the
Priority: 1
cdrini
approved these changes
Mar 3, 2026
|
|
||
| fq = None | ||
| if mode == "ebooks": | ||
| from openlibrary.solr.solr import get_fulltext_min |
Collaborator
There was a problem hiding this comment.
Oooof! That's shocking that wasn't auto-caught... it would be great to automate errors for non-existant dependencies!
Collaborator
Author
There was a problem hiding this comment.
Yeah it wasn't caught because we haven't enabled #11073 yet.
I think we should do that soon. I'll update the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were importing the wrong thing in a bad copy/paste not caught by mypy (but caught by
ty)