Selector: Stop relying on CSS.supports( "selector(...)" )#5206
Merged
mgol merged 3 commits intojquery:mainfrom Feb 14, 2023
Merged
Selector: Stop relying on CSS.supports( "selector(...)" )#5206mgol merged 3 commits intojquery:mainfrom
mgol merged 3 commits intojquery:mainfrom
Conversation
mgol
added
Selector
Needs review
Discuss in Meeting
Member
Author
|
I didn't write any new unit tests. I was wondering whether to do that but while being able to leverage the more forgiving native |
Member
Author
|
I still need to prepare a version for |
mgol
force-pushed
the
has-non-forgiving
branch
from
dd53fce to
c4e033c
Compare
2 tasks
Member
Author
|
The |
Member
Author
|
Sizzle PR: jquery/sizzle#493 |
timmywil
approved these changes
Feb 13, 2023
timmywil
removed
the
Discuss in Meeting
mgol
commented
Feb 13, 2023
gibson042
approved these changes
Feb 13, 2023
Member
gibson042
left a comment
gibson042
left a comment
There was a problem hiding this comment.
LGTM! I left some comment rewording suggestions.
`CSS.supports( "selector(...)" )` has different semantics than selectors passed to `querySelectorAll`. Apart from the fact that the former returns `false` for unrecognized selectors and the latter throws, `qSA` is more forgiving and accepts some invalid selectors, auto-correcting them where needed - for example, mismatched brackers are auto-closed. This behavior difference is breaking for many users. To add to that, a recent CSSWG resolution made `:is()` & `:where()` the only pseudos with forgiving parsing; browsers are in the process of making `:has()` parsing unforgiving. Taking all that into account, we go back to our previous try-catch approach without relying on `CSS.supports( "selector(...)" )`. The only difference is we detect forgiving parsing in `:has()` and mark the selector as buggy. The PR also updates `playwright-webkit` so that we test against a version of WebKit that already has non-forgiving `:has()`. Fixes jquerygh-5194 Ref jquerygh-5098 Ref jquerygh-5107 Ref w3c/csswg-drafts#7676
Co-authored-by: Richard Gibson <[email protected]>
mgol
force-pushed
the
has-non-forgiving
branch
from
880fad5 to
5817baa
Compare
mgol
added a commit
that referenced
this pull request
Feb 14, 2023
`CSS.supports( "selector(...)" )` has different semantics than selectors passed to `querySelectorAll`. Apart from the fact that the former returns `false` for unrecognized selectors and the latter throws, `qSA` is more forgiving and accepts some invalid selectors, auto-correcting them where needed - for example, mismatched brackers are auto-closed. This behavior difference is breaking for many users. To add to that, a recent CSSWG resolution made `:is()` & `:where()` the only pseudos with forgiving parsing; browsers are in the process of making `:has()` parsing unforgiving. Taking all that into account, we go back to our previous try-catch approach without relying on `CSS.supports( "selector(...)" )`. The only difference is we detect forgiving parsing in `:has()` and mark the selector as buggy. The PR also updates `playwright-webkit` so that we test against a version of WebKit that already has non-forgiving `:has()`. Fixes gh-5194 Closes gh-5207 Ref gh-5206 Ref gh-5098 Ref gh-5107 Ref w3c/csswg-drafts#7676
mgol
added a commit
to jquery/sizzle
that referenced
this pull request
Feb 14, 2023
`CSS.supports( "selector(...)" )` has different semantics than selectors passed to `querySelectorAll`. Apart from the fact that the former returns `false` for unrecognized selectors and the latter throws, `qSA` is more forgiving and accepts some invalid selectors, auto-correcting them where needed - for example, mismatched brackers are auto-closed. This behavior difference is breaking for many users. To add to that, a recent CSSWG resolution made `:is()` & `:where()` the only pseudos with forgiving parsing; browsers are in the process of making `:has()` parsing unforgiving. Taking all that into account, we go back to our previous try-catch approach without relying on `CSS.supports( "selector(...)" )`. The only difference is we detect forgiving parsing in `:has()` and mark the selector as buggy. Fixes jquery/jquery#5194 Closes gh-493 Ref jquery/jquery#5098 Ref jquery/jquery#5206 Ref jquery/jquery#5207 Ref gh-486 Ref w3c/csswg-drafts#7676
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CSS.supports( "selector(...)" )has different semantics than selectors passed toquerySelectorAll. Apart from the fact that the former returnsfalsefor unrecognized selectors and the latter throws,qSAis more forgiving and accepts some invalid selectors, auto-correcting them where needed - for example, mismatched brackets are auto-closed. This behavior difference is breaking for many users.To add to that, a recent CSSWG resolution made
:is()&:where()the only pseudos with forgiving parsing; browsers are in the process of making:has()parsing unforgiving.Taking all that into account, we go back to our previous try-catch approach without relying on
CSS.supports( "selector(...)" ). The only difference is we detect forgiving parsing in:has()and mark the selector as buggy.The PR also updates
playwright-webkitso that we test against a version of WebKit that already has non-forgiving:has().Fixes gh-5194
Ref gh-5098
Ref gh-5107
Ref w3c/csswg-drafts#7676
-41 bytes
Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com