[TypeScript] Fix withLifecycleCallback return type for augmented data providers#11170
Merged
[TypeScript] Fix withLifecycleCallback return type for augmented data providers#11170
Conversation
WiXSL
requested changes
Feb 23, 2026
| dataProvider.getMany('posts', { ids: [1, 2] }); | ||
| expect(resourceCallback.beforeGetMany).toHaveBeenCalled(); | ||
| }); | ||
| it('should return the right type for augmented Data Providers', async () => { |
Collaborator
There was a problem hiding this comment.
This test still passes with the old dataProvider return signature
Member
Author
There was a problem hiding this comment.
right, but the test itself doesn't pass TS compilation unless e do the change.
WiXSL
approved these changes
Feb 23, 2026
slax57
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
withLifecycleCallbacksalways returns an object of typeDataProvider.This can be an issue when developers add custom methods to the data provider and use a custom type. In that case, the original type is lost.
Solution
Infer the return type from the data generator param type.
How To Test
New unit test added.
Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a feature[ ] The PR includes one or several stories (if not possible, describe why)[ ] The documentation is up to date