feat(test runner): do not mock tty in the worker process#30107
Merged
dgozman merged 1 commit intomicrosoft:mainfrom Mar 25, 2024
Merged
feat(test runner): do not mock tty in the worker process#30107dgozman merged 1 commit intomicrosoft:mainfrom
dgozman merged 1 commit intomicrosoft:mainfrom
Conversation
mxschmitt
approved these changes
Mar 25, 2024
This comment has been minimized.
This comment has been minimized.
This was historically done to make `console.log()` have colors. However, this makes any other code that checks `process.stdout.isTTY` incorrectly assume real TTY support. Node18 and Node20 now respect `FORCE_COLOR=1` in console, so our default behavior of forcing colors in the worker process just works out of the box.
dgozman
force-pushed
the
tr-remove-tty-mock
branch
from
116c042 to
6b8f0b0
Compare
Contributor
Test results for "tests 1"4 flaky26863 passed, 625 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was historically done to make
console.log()have colors. However, this makes any other code that checksprocess.stdout.isTTYincorrectly assume real TTY support.Node18 and Node20 now respect
FORCE_COLOR=1in console, so our default behavior of forcing colors in the worker process just works out of the box. See nodejs/node#48034.