Fix export from interactive

[IanMatthewHuff]

For #14210

• Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
• Title summarizes what is changing.
• Has a news entry file (remember to thank yourself!).
• Appropriate comments and documentation strings in the code.
• Has sufficient logging.
• Has telemetry for enhancements.
• Unit tests & system/integration tests are added/updated.
• Test plan is updated as appropriate.
• package-lock.json has been regenerated by running npm install (if dependencies have changed).
• The wiki is updated with any design decisions/details.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
0.0% Duplication

[IanMatthewHuff]

Looks like export from interactive wasn't actually broken from the nbconvert fix. It had been broken a while ago by the backup storage fix here.

245f393

@rchiodo I think that this would work if it was a bind(this) but from the code I'm not seeing why this was needed as part of the backup fix. Was this needed for a reason?

[codecov-commenter]

Codecov Report

Merging #14224 into main will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #14224      +/-   ##
==========================================
- Coverage   59.96%   59.95%   -0.01%     
==========================================
  Files         706      706              
  Lines       39183    39185       +2     
  Branches     5683     5683              
==========================================
- Hits        23495    23494       -1     
+ Misses      14465    14454      -11     
- Partials     1223     1237      +14     

Impacted Files	Coverage Δ
...atascience/interactive-window/interactiveWindow.ts	9.30% <0.00%> (ø)
src/client/common/utils/platform.ts	68.00% <0.00%> (-4.00%)	⬇️
src/client/datascience/jupyter/jupyterNotebook.ts	4.21% <0.00%> (-0.33%)	⬇️
src/client/logging/levels.ts	61.11% <0.00%> (ø)
src/client/logging/logger.ts	62.74% <0.00%> (ø)
src/client/logging/formatters.ts	53.57% <0.00%> (ø)
src/client/logging/transports.ts	65.11% <0.00%> (ø)
...datascience/editor-integration/cellhashprovider.ts	75.36% <0.00%> (+0.12%)	⬆️
src/client/pythonEnvironments/index.ts	17.07% <0.00%> (+1.28%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfe12a7...390c2c6. Read the comment docs.

[IanMatthewHuff]

Should fix #14099

[DonJayamanne]

Oops, my bad, i fixed this in our internal branch

[IanMatthewHuff]

Two repo tax :(

[rchiodo]

Looks like export from interactive wasn't actually broken from the nbconvert fix. It had been broken a while ago by the backup storage fix here.

245f393

@rchiodo I think that this would work if it was a bind(this) but from the code I'm not seeing why this was needed as part of the backup fix. Was this needed for a reason?

I have no idea. Doesn't seem correct to me. I would guess some sort of merge problem. Why would I even change that line for backup? There was a lot of merging going on when I submitted this originally. I'd guess that's where I made the mistake

[IanMatthewHuff]

I have no idea. Doesn't seem correct to me. I would guess some sort of merge problem. Why would I even change that line for backup? There was a lot of merging going on when I submitted this originally. I'd guess that's where I made the mistake

@rchiodo Sounds good. That was what it looked like, but I wanted to make sure that I wasn't regressing something intentional.