api/types/image: make InspectResponse.GraphDriver optional#50893
Merged
thaJeztah merged 1 commit intomoby:masterfrom Sep 4, 2025
Merged
Conversation
eb8b9c6 to
b5451b7
Compare
dmcgowan
reviewed
Sep 4, 2025
api/types/image/image_inspect.go
Outdated
| // GraphDriver holds information about the storage driver used to store the | ||
| // container's and image's filesystem. | ||
| GraphDriver storage.DriverData | ||
| GraphDriver storage.DriverData `json:"GraphDriver,omitempty"` |
Member
There was a problem hiding this comment.
Omit empty is respected on non-pointer structs if all the sub-fields of the struct are also empty?
Contributor
Author
There was a problem hiding this comment.
Good catch I think you are right it would be not be effective here.
b5451b7 to
56ca2fc
Compare
Member
|
Needs a rebase, @austinvazquez |
Member
|
docker-py test failures should also be checked probably; they could be legit (and possibly have to be adjusted, and temporarily skipped) cc @ctalledo |
This change makes the `GraphDriver` field in `image.InspectResponse` optional. This field will only be returned when using moby engine graph drivers as a backend storage implementation. It will be omitted when using the containerd image backend. Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
56ca2fc to
c441b2e
Compare
Contributor
Author
|
@thaJeztah , looks like it was a flake. It reran on the rebase. |
dmcgowan
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Split from #50857
This change makes the
GraphDriverfield inimage.InspectResponseoptional. This field will only be returned when using moby engine graph drivers as a backend storage implementation. It will be omitted when using the containerd image backend.- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)