daemon: ignore duplicate task exit events in daemon state#51925
Merged
cpuguy83 merged 1 commit intomoby:masterfrom Jan 27, 2026
Merged
daemon: ignore duplicate task exit events in daemon state#51925cpuguy83 merged 1 commit intomoby:masterfrom
cpuguy83 merged 1 commit intomoby:masterfrom
Conversation
Handle duplicate TaskExit events by checking container state and timestamps while holding the container lock. Ignore late duplicates when restarting or when a newer task is already running. Signed-off-by: Wei Fu <fuweid89@gmail.com>
Contributor
Author
|
ping @dmcgowan @AkihiroSuda for review when you have chance. thanks |
corhere
approved these changes
Jan 27, 2026
cpuguy83
approved these changes
Jan 27, 2026
This was referenced Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
to avoid reprocessing late exits.
- How I did it
shouldIgnoreExitEventWithLockindaemon/monitor.goand invokedit from
handleContainerExitwhile holding the container lock.restart is in progress and the exit timestamp is newer than FinishedAt, or
when a new task is already running and the exit predates StartedAt.
- How to verify it
panic during restart) and confirm no state regressions.
docker run -d --runtime runc-fp --annotation "io.containerd.runtime.v2.shim.failpoint.Delete=1*panic(oops)" ubuntu:latest sleep 5- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)
REF: #46212