Initialize $since variable#166
Closed
lukascellar wants to merge 1 commit intonette:masterfrom
lukascellar:patch-1
Closed
Initialize $since variable#166lukascellar wants to merge 1 commit intonette:masterfrom lukascellar:patch-1
lukascellar wants to merge 1 commit intonette:masterfrom
lukascellar:patch-1
Conversation
Variable $since at line 1172 is undefined and causes PHP Notice.
Member
|
This should never happen (line 1164). What's your structure components? |
7447ad4 to
3165d3a
Compare
3fb5d4a to
d2e3dc1
Compare
07d4ebb to
337c67c
Compare
7c8af57 to
ec7d92a
Compare
d186075 to
4fedb44
Compare
|
@lukascellar Could you provide more details? |
Author
|
It occurs in dashboard of my application, some dashboard controls are registered dynamically in DI extension (modular application, module can add component to dashboard).
|
dg
added a commit
that referenced
this pull request
Apr 12, 2017
|
Thank you Lukáši for nice report. And you Davide for fast fixup! |
Member
|
Mira Cizek described it here https://forum.nette.org/en/28423-undefined-variable-since-did-you-mean-sinces#p186866 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variable $since at line 1172 is undefined and causes PHP Notice.