SQLiteJournal: performance improvements

[sallyx]

SQLiteJournal: performance improvements

[milo]

Good point when there are no foreign keys.

[milo]

Could you change commit message to be consistent and add test to priority bugfix?

[sallyx]

I have updated the test file already.

[Majkl578]

fixed bug - keys with multiple priority

This should be in separate PR (or commit at least).

[sallyx]

I have created a new PR #35 for the bug fix.

[milo]

With following synthetic benchmark:

use Nette\Caching\Cache;
use Nette\Caching\Storages\SQLiteJournal;

require __DIR__ . '/../caching/vendor/autoload.php';

$keys = $tags = $dels = [];
foreach (range(1, 200) as $i) {
    $keys[] = "key-$i";
    $tags[] = "tag-$i";
    if (($i % 4) === 0) $dels[] = "tag-$i";
}

$journal = new SQLiteJournal(__DIR__ . '/bench.s3db');

foreach (range(1, 10) as $loop) {
    # One key, multiple tags
    $journal->write('key', [Cache::TAGS => $tags]);

    # n-keys, one tag
    foreach ($keys as $key) {
        $journal->write($key, [Cache::TAGS => ['tag']]);
    }

    # Delete some of tags
    $journal->clean([Cache::TAGS => $dels]);
}

Apache sequential bench:

$ rm -f bench.s3db
$ ab -c 1 -n 10 http://localhost/dev/nette/caching.tests/bench.php

# Before patch
Connect:        0    0   0.0      0       0
Processing:  3906 5036 836.1   5288    6365
Waiting:     3906 5036 836.1   5288    6365
Total:       3906 5036 836.1   5288    6365

# With patch
Connect:        0    0   0.0      0       0
Processing:   686  783 149.3    704    1145
Waiting:      686  783 149.3    704    1145
Total:        686  783 149.3    704    1145

Apache parallel bench:

$ rm -f bench.s3db
$ ab -c 8 -n 10 http://localhost/dev/nette/caching.tests/bench.php

# Before patch
Connect:        0    0   0.1      0       0
Processing:  6567 36465 16157.5  45939   51092
Waiting:     6567 36465 16157.5  45939   51092
Total:       6567 36465 16157.6  45939   51092

# With patch
Connect:        0    0   0.1      0       0
Processing:  2739 4437 1425.3   4443    6845
Waiting:     2739 4437 1425.3   4443    6845
Total:       2740 4437 1425.3   4444    6845

So 👍 for merge.

[milo]

@sallyx Could you change the commit message to something like: SQLiteJournal: performance improvements

[dg]

@sallyx not title but commit message