Cache: create dependencies when closing macro#49
Merged
dg merged 1 commit intonette:masterfrom Jan 29, 2017
vitkutny:cache-dependencies
Merged
Cache: create dependencies when closing macro#49dg merged 1 commit intonette:masterfrom vitkutny:cache-dependencies
dg merged 1 commit intonette:masterfrom
vitkutny:cache-dependencies
Conversation
- prevents invalid expiration from dependencies callback when caching time-expensive data
492413c to
b0b475e
Compare
6037e83 to
1fe69cc
Compare
1655c0f to
7c885a2
Compare
29c60cc to
62bf8ec
Compare
dg
pushed a commit
that referenced
this pull request
Jan 29, 2017
- prevents invalid expiration from dependencies callback when caching time-expensive data
dg
pushed a commit
that referenced
this pull request
Jan 29, 2017
- prevents invalid expiration from dependencies callback when caching time-expensive data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prevents invalid expiration from dependencies callback when caching time-expensive data
example of code causing problem:
current behaviour:
content is cached with zero expiration (-1 second)
expected behaviour:
content is cached for 1 second