Skip to content

PHP 7.2 fixed parameter passed to count#190

Merged
dg merged 2 commits intonette:masterfrom
ondrakub:php72-fixed-count-parameter
Dec 13, 2017
Merged

PHP 7.2 fixed parameter passed to count#190
dg merged 2 commits intonette:masterfrom
ondrakub:php72-fixed-count-parameter

Conversation

@ondrakub
Copy link
Contributor

  • bug fix? yes
  • new feature? no
  • BC break? no

The $ref variable could have null value and in PHP 7.2 parameter in count can only be an array or an object implements Countable

@JanTvrdik
Copy link
Contributor

Or can probably simply replace count($ref) with count($ref ?? [])

@ondrakub
Copy link
Contributor Author

@JanTvrdik yes, that's even better. I've just pushed commit.

@dg
Copy link
Member

dg commented Dec 13, 2017

Thanks

@dg dg merged commit 544c164 into nette:master Dec 13, 2017
dg pushed a commit that referenced this pull request Feb 5, 2018
* fixed Warning: count(): Parameter must be an array or an object that implements Countable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants