Implement SQL Clause in Where IS NOT NULL#226

nargotik · 2019-04-12T16:21:24Z

new feature
BC break no
doc PR: nette/docs

Allow usage of IS NOT NULL Passing arguments on array like 'database_field NOT' => NULL, Will represent SQL query `database_field` IS NOT NULL

dg · 2019-04-12T16:27:13Z

Please do not reopen new pull request, you can change code via force push.

Allow usage of IS NOT NULL Passing arguments on array like 'database_field NOT' => NULL, Will represent SQL query `database_field` IS NOT NULL

nargotik · 2019-04-12T16:29:46Z

Sorry about it, i'm kinda noob in Git :)

Allow usage of IS NOT NULL Passing arguments on array like 'database_field NOT' => NULL, Will represent SQL query `database_field` IS NOT NULL

nargotik · 2019-04-22T10:30:11Z

Please do not reopen new pull request, you can change code via force push.

Have you view this implementation ?

matej21 · 2019-04-23T07:11:32Z

@nargotik test is still missing.
I think it should be enough if you modify this test:

database/tests/Database/SqlPreprocessor.phpt

Line 101 in 8b6230d

test(function () use ($preprocessor) { // where

nargotik · 2019-04-23T10:18:26Z

@nargotik test is still missing.
I think it should be enough if you modify this test:

database/tests/Database/SqlPreprocessor.phpt

Line 101 in 8b6230d

test(function () use ($preprocessor) { // where

Ok added, test

Failing test from coveralls mentions a file not changed at all :-)
Failing test appveyor is because of dns problem in getcomposer

dg · 2019-04-23T15:03:39Z

Thanks!

Daniel added 2 commits April 12, 2019 17:08

Implement Where Cause IS NOT NULL

c1c2a17

Allow usage of IS NOT NULL Passing arguments on array like 'database_field NOT' => NULL, Will represent SQL query `database_field` IS NOT NULL

Implement Where Cause IS NOT NULL

929104c

Allow usage of IS NOT NULL Passing arguments on array like 'database_field NOT' => NULL, Will represent SQL query `database_field` IS NOT NULL

Implement Where Cause IS NOT NULL

f646690

Allow usage of IS NOT NULL Passing arguments on array like 'database_field NOT' => NULL, Will represent SQL query `database_field` IS NOT NULL

Daniel added 2 commits April 12, 2019 17:32

Implement Where Cause IS NOT NULL

186e403

Allow usage of IS NOT NULL Passing arguments on array like 'database_field NOT' => NULL, Will represent SQL query `database_field` IS NOT NULL

Implement Where Cause IS NOT NULL

4c7d646

Allow usage of IS NOT NULL Passing arguments on array like 'database_field NOT' => NULL, Will represent SQL query `database_field` IS NOT NULL

Daniel and others added 9 commits April 23, 2019 09:40

Missing test added

6e59a67

Test correction

1559936

Test correction

e0c2556

Tests correction

1aed75f

WHERE test changes for this improvement

3b69123

WHERE test changes for this improvement

93ebbbc

Merge branch 'master' of https://github.com/nargotik/database

3e7b867

Date field don't exists in test database

06020f0

removed wrong commited .idea

6fe82f1

nargotik added 4 commits April 23, 2019 12:06

added test

9a7623a

Merge branch 'master' of https://github.com/nargotik/database

0a650ab

test corrected

9fa1167

Merge branch 'master' of https://github.com/nargotik/database

6ea4c78

dg merged commit ff54cdc into nette:master Apr 23, 2019

dg pushed a commit that referenced this pull request Apr 23, 2019

SqlPreprocessor: generates IS NOT NULL (#226)

9eeebcc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement SQL Clause in Where IS NOT NULL#226