Fix bug missing setting setOmitted(true) in Button.php#330
Merged
dg merged 1 commit intonette:masterfrom Aug 5, 2024
mildabre:patch-2
Merged
Fix bug missing setting setOmitted(true) in Button.php#330dg merged 1 commit intonette:masterfrom mildabre:patch-2
dg merged 1 commit intonette:masterfrom
mildabre:patch-2
Conversation
If form is submitted with standard SubmitButton and in the form is another button Button, the attribute name + value appears in $values of the form. This is undesirable behaviour and my proposal fixes this bug.
dg
force-pushed
the
master
branch
6 times, most recently
from
94f43f0 to
fe374c5
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
5b93c75 to
2146e59
Compare
dg
pushed a commit
that referenced
this pull request
Aug 5, 2024
dg
pushed a commit
that referenced
this pull request
Aug 5, 2024
dg
pushed a commit
that referenced
this pull request
Aug 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If form is submitted with standard SubmitButton and in the form is another button Button, the attribute name + value appears in $values of the form. This is undesirable behaviour and my proposal fixes this bug.
Notice: in the class Nette\Forms\Controls\SubmitButton in constructor is similar call setOmitted(true) which would be redundant after accepting this PR and could be removed for simplicity. I will send another PR.