Fix: validate() on forms where is attached non-form component causes error#86
Closed
ovlach wants to merge 1 commit intonette:masterfrom
Closed
Fix: validate() on forms where is attached non-form component causes error#86ovlach wants to merge 1 commit intonette:masterfrom
ovlach wants to merge 1 commit intonette:masterfrom
Conversation
ovlach
changed the title
Contributor
|
I really like the solution, but I'm not 100% sure if this is not a bc break. |
Member
|
Related to 347c545 |
Member
|
@ovlach The interface is needless here. Can you simplyfied it by adding check that component is form |
Contributor
|
I like the interface. |
Member
|
Validation will be redesigned in future in another way and this interface is not (will not be) suitable. |
dg
force-pushed
the
master
branch
2 times, most recently
from
9e359e6 to
fa84d63
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
3c1619a to
31bc0a3
Compare
dg
force-pushed
the
master
branch
7 times, most recently
from
6b04b51 to
d1c30d6
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
fd381fb to
b70e5da
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
9470e5f to
4d5f6c3
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
81549c5 to
98832d3
Compare
dg
force-pushed
the
master
branch
6 times, most recently
from
2b44619 to
4473513
Compare
dg
added a commit
that referenced
this pull request
Jun 30, 2016
dg
added a commit
that referenced
this pull request
Jun 30, 2016
dg
added a commit
that referenced
this pull request
Jun 30, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validate() on forms where is attached non-form component causes error - older nette/form using getControls() method where is interface checking.
Now this is not possible, so i create special IValidatable interface which marks controls and container as validatable and checking it.