IResponse: added HTTP response codes from accepted RFC 6585#107
IResponse: added HTTP response codes from accepted RFC 6585#107dg merged 1 commit intonette:masterfrom
Conversation
fprochazka
left a comment
There was a problem hiding this comment.
There are still few missing https://github.com/symfony/symfony/blob/ac3cb6f03487561050001ad81d7308a3e0fa35e0/src/Symfony/Component/HttpFoundation/Response.php#L19, do you think you could add them all please?
|
Do you think this is useful? |
|
@fprochazka Yes, I will add them. |
|
@dg it's better to have those codes as constants. And it's weird to have half defined in nette and half in custom class. |
|
There is even more codes missing here, see Symfony's Response constants: https://github.com/symfony/symfony/blob/c0a26bc/src/Symfony/Component/HttpFoundation/Response.php#L21-L82 |
|
I've added all missing response codes |
|
🎩 |
|
As for community-driven development this a good pull request! 👍 |
|
@matyx awesome 👍 |
RFC: https://tools.ietf.org/html/rfc6585