Url: IDN domain automatically convert to UTF-8.#190
Merged
dg merged 12 commits intonette:masterfrom Jan 5, 2021
Merged
Conversation
…), canonicalize()
bda06a4 to
e791a00
Compare
Member
|
Thanks |
dg
pushed a commit
that referenced
this pull request
Jan 5, 2021
dg
pushed a commit
that referenced
this pull request
Jan 15, 2021
dg
pushed a commit
that referenced
this pull request
Jan 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By documentation (more info: https://www.php.net/manual/en/function.idn-to-utf8.php) the domain
xn--tst-qla.deis same astäst.de, but Nette Url claims that it is a different URLs:This modification adds automatic conversion of IDN domains to UTF-8 format (if an extension is available). Prior to conversion, the use of IDNs is detected to maintain maximum performance.
If a particular PHP does not have an extension, it can be replaced by the
symfony/polyfill-intl-idnpackage.Thanks.