Allow using a default stream context#19
Closed
robbertkl wants to merge 1 commit intonette:masterfrom
robbertkl:master
Closed
Allow using a default stream context#19robbertkl wants to merge 1 commit intonette:masterfrom robbertkl:master
robbertkl wants to merge 1 commit intonette:masterfrom
robbertkl:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately,
fsockopen()does not respectstream_context_set_default(). However, replacing it withstream_socket_client()resolves this. It will allow setting custom stream context options, without any substantial changes toSmtpMailer.Of course, it would be nice if a stream context could be passed to the
SmtpMailer(see #8), but until that's implemented, this will accomplish pretty much the same thing.