Support configuring spaces between methods#30
Closed
deviantintegral wants to merge 3 commits intonette:masterfrom
Closed
Support configuring spaces between methods#30deviantintegral wants to merge 3 commits intonette:masterfrom
deviantintegral wants to merge 3 commits intonette:masterfrom
Conversation
deviantintegral
force-pushed
the
method-spacing
branch
from
7daf620 to
8759484
Compare
Member
|
I added the PsrPrinter that solves this issue: $printer = new Nette\PhpGenerator\PsrPrinter;
$class = new Nette\PhpGenerator\ClassType('Demo');
// ...
echo $printer->printClass($class); // 4 spaces indentation |
dg
added a commit
that referenced
this pull request
Aug 6, 2018
dg
added a commit
that referenced
this pull request
Aug 6, 2018
dg
added a commit
that referenced
this pull request
Aug 6, 2018
dg
added a commit
that referenced
this pull request
Aug 6, 2018
dg
added a commit
that referenced
this pull request
Aug 9, 2018
dg
added a commit
that referenced
this pull request
Aug 9, 2018
dg
added a commit
that referenced
this pull request
Aug 9, 2018
dg
added a commit
that referenced
this pull request
Aug 9, 2018
dg
added a commit
that referenced
this pull request
Aug 29, 2018
dg
added a commit
that referenced
this pull request
Aug 29, 2018
dg
added a commit
that referenced
this pull request
Aug 29, 2018
dg
added a commit
that referenced
this pull request
Aug 29, 2018
dg
added a commit
that referenced
this pull request
Aug 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I see that nette places two spaces between methods which is fine, but doesn't match most other PHP projects. This PR makes the spacing configurable while leaving the default at 2 spaces.