Method::from($from) loads method body as well#4
Closed
uestla wants to merge 1 commit intonette:masterfrom
Closed
Conversation
Member
|
Can you add a test please? (Test it with some class from minified Nette and PDO) |
|
❤️ Awesome! But I guess it won't pass for <?php class A{function a(){return 'Aa';}}class B{function a(){return'Ba';} function b() {return'Bb';}function c(){return'Bc';}}class C{function a() {return'Ca';}}Basically you would need to parse php code with context buffer to make it bullet proof and use begin and end for optimization. |
Contributor
Author
|
@mishak87 Right ... Not to mention multiple namespaces and all that on one line... |
|
I didn't mean to discourage you from doing it. Such feature would be really useful ie. it could simplify significantly generation of certain proxies. Probably it would be better to lazy load it for performance reasons but it is possible to do it. |
dg
added a commit
that referenced
this pull request
May 6, 2020
dg
added a commit
that referenced
this pull request
May 6, 2020
dg
added a commit
that referenced
this pull request
May 6, 2020
dg
added a commit
that referenced
this pull request
May 6, 2020
dg
added a commit
that referenced
this pull request
May 6, 2020
dg
added a commit
that referenced
this pull request
May 6, 2020
dg
added a commit
that referenced
this pull request
May 6, 2020
dg
added a commit
that referenced
this pull request
May 26, 2020
dg
added a commit
that referenced
this pull request
May 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.