Toggle for resolving of class names when using withBodyFrom functionality#85
Merged
dg merged 2 commits intonette:v3.5from Aug 27, 2021
wikando:v3.5
Merged
Toggle for resolving of class names when using withBodyFrom functionality#85dg merged 2 commits intonette:v3.5from wikando:v3.5
dg merged 2 commits intonette:v3.5from
wikando:v3.5
Conversation
Member
|
That's great, thanks. Could you add a test? |
Author
|
Yes! Will do it when I have more time :) |
65fcbb1 to
605a107
Compare
Member
|
I totally understand the first commit with the replacing of class names inside the function bodies, this is of course useful and I merged it. But I don't understand the point of the second commit. On the one hand it goes against type resolving in the Printer, and anyway it would have to be done differently, because the last segment of the class name might not be sufficient, for example in the case of |
dg
added a commit
that referenced
this pull request
Sep 21, 2021
dg
added a commit
that referenced
this pull request
Sep 21, 2021
dg
added a commit
that referenced
this pull request
Sep 21, 2021
dg
added a commit
that referenced
this pull request
Sep 21, 2021
dg
added a commit
that referenced
this pull request
Sep 21, 2021
dg
added a commit
that referenced
this pull request
Sep 22, 2021
dg
added a commit
that referenced
this pull request
Sep 22, 2021
dg
added a commit
that referenced
this pull request
Sep 22, 2021
dg
added a commit
that referenced
this pull request
Sep 23, 2021
dg
added a commit
that referenced
this pull request
Sep 23, 2021
dg
added a commit
that referenced
this pull request
Sep 23, 2021
dg
added a commit
that referenced
this pull request
Sep 23, 2021
dg
added a commit
that referenced
this pull request
Sep 23, 2021
dg
added a commit
that referenced
this pull request
Sep 23, 2021
dg
added a commit
that referenced
this pull request
Sep 23, 2021
dg
added a commit
that referenced
this pull request
Sep 23, 2021
dg
added a commit
that referenced
this pull request
Sep 23, 2021
dg
added a commit
that referenced
this pull request
Sep 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to create a class from an existing file and move it to another location with another namespace, it was necessary to be able to disable the replacing of class names in function bodies with fully qualified versions, and rather relying on correct use statements.
Also made the change in the most harmless way so nothing breaks 🤞
Hope this is a valuable addition :)