Allow Schema elements as default values#12
Merged
dg merged 1 commit intonette:masterfrom Oct 31, 2019
mabar:patch-1
Merged
Conversation
Member
|
Great. Can you add test? |
Contributor
Author
|
Done |
Member
|
Thanks |
dg
pushed a commit
that referenced
this pull request
Oct 31, 2019
dg
pushed a commit
that referenced
this pull request
Oct 31, 2019
dg
pushed a commit
that referenced
this pull request
Oct 31, 2019
Member
|
Wouldn't it be better to use this solution, ie method that sets the first item as the default? Expect::anyOf(
$subExtensionSchema
false,
)->firstAsDefault(), |
Contributor
Author
|
Imho it's better to keep that behavior hidden. If I implemented this now, I would throw exception for any But yeah, may be a nice shortcut. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have some composite extensions which simulates compiler passes. They can be disabled so configuration looks like this
Expect::anyOf(false, SubExtension::createSchema()).AnyOf does not match default value null (empty configuration) same way as if we directly use Expect::structure (no AnyOf) so that structure is not used.
Current workaround looks like this
With suggested change would be simplified call to
defaulttodefault($subExtensionSchema)and it also allows any schemas used as default values.Alternative solution would be match Structure with null value in AnyOf but I am not sure if it's a correct behavior as it would depend on order of structure and null if both used and maybe break also some other combinations.