fix(msvs): do not fix paths in action command arguments#84
fix(msvs): do not fix paths in action command arguments#84gengjiawen merged 1 commit intonodejs:masterfrom
Conversation
BREAKING CHANGE: On Windows, arguments passed to the "action" commands are no longer transformed to replace slashes with backslashes.
|
Node.js Windows integration is expected to fail because |
|
This change is necessary to update to V8 8.8, as it expects the paths passed to torque to always have forward slashes. |
|
@nodejs/gyp / @nodejs/node-gyp what do you think? |
|
Anything we can do to fix windows build on this repo. Merge this will most likely breaks CI for other PR. |
|
it's kind of a chicken and egg problem. We have to land something first either here or in nodejs/node, and CI will be broken until the other change is landed. I think it's ok to break 1 workflow here, if we don't take too much time to update node afterwards |
Sounds good to me. Let's merge it :) |
This is a revert of nodejs/gyp-next#84 with a change to the _FixPath function allowing to change the separator used. Fixes: nodejs/gyp-next#120 Fixes: nodejs#2485
* fix(msvs): fix paths again in action command arguments This is a revert of #84 with a change to the _FixPath function allowing to change the separator used. Fixes: #120 Fixes: nodejs/node-gyp#2485
2 participants
BREAKING CHANGE: On Windows, arguments passed to the "action" commands are no longer transformed to replace slashes with backslashes.