fix: npm exec does not use script-shell option to run commands#5297
Merged
fritzy merged 1 commit intonpm:latestfrom Aug 17, 2022
lux01:latest
Merged
fix: npm exec does not use script-shell option to run commands#5297fritzy merged 1 commit intonpm:latestfrom lux01:latest
fritzy merged 1 commit intonpm:latestfrom
lux01:latest
Conversation
Member
|
Ah yep, |
wraithgar
approved these changes
Aug 11, 2022
Member
wraithgar
left a comment
There was a problem hiding this comment.
libnpmexec tests need to be refactored to use spawk. That's outside the scope of this PR though.
Merged
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm exec/npxdo not fully respect thescript-shellparameter. When combined with npm/run-script#103 this means that users on AIX cannot runnpx/npm execcommands even withscript-shellset tobash.For example:
References
Related to npm/run-script#103