Merged
Conversation
njsmith
approved these changes
Oct 4, 2021
Contributor
njsmith
left a comment
njsmith
left a comment
There was a problem hiding this comment.
LGTM. Codecov seems to be claiming that there's a line somewhere that's no longer being covered, which might mean there's another line that can be removed? I failed at deciphering its output though. Do you care?
Contributor
|
Meh, having stared at the codecov report some more I'm pretty sure the complaint about new uncovered lines is just some kind of artifact. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
let CI be my guide