[PR #12744/c947145f backport][8.3.x] Replaced typing.Self with typing_extensions.Self#12746
Merged
nicoddemus merged 9 commits into8.3.xfrom Aug 29, 2024
Conversation
Fix incorrect Self import from typing instead of typing_extensions. --------- Co-authored-by: Bruno Oliveira <bruno@soliv.dev> (cherry picked from commit c947145)
updates: - [github.com/astral-sh/ruff-pre-commit: v0.5.2 → v0.5.4](astral-sh/ruff-pre-commit@v0.5.2...v0.5.4) - [github.com/pre-commit/mirrors-mypy: v1.10.1 → v1.11.0](pre-commit/mirrors-mypy@v1.10.1...v1.11.0)
updates: - [github.com/astral-sh/ruff-pre-commit: v0.5.4 → v0.5.5](astral-sh/ruff-pre-commit@v0.5.4...v0.5.5) - [github.com/asottile/pyupgrade: v3.16.0 → v3.17.0](asottile/pyupgrade@v3.16.0...v3.17.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.5.5 → v0.5.6](astral-sh/ruff-pre-commit@v0.5.5...v0.5.6) - [github.com/pre-commit/mirrors-mypy: v1.11.0 → v1.11.1](pre-commit/mirrors-mypy@v1.11.0...v1.11.1) - [github.com/tox-dev/pyproject-fmt: 2.1.4 → 2.2.1](tox-dev/pyproject-fmt@2.1.4...2.2.1)
According to https://pypi.org/project/types-pkg-resources/#history, that package has been supplanted by `types-setuptools`.
* [pre-commit.ci] pre-commit autoupdate updates: - [github.com/astral-sh/ruff-pre-commit: v0.5.6 → v0.5.7](astral-sh/ruff-pre-commit@v0.5.6...v0.5.7) * Apply pyupgrade latest changes Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.5.7 → v0.6.1](astral-sh/ruff-pre-commit@v0.5.7...v0.6.1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.6.1 → v0.6.2](astral-sh/ruff-pre-commit@v0.6.1...v0.6.2) - [github.com/pre-commit/mirrors-mypy: v1.11.1 → v1.11.2](pre-commit/mirrors-mypy@v1.11.1...v1.11.2) * Fix sphinx with a more robust fix Until sphinx-contrib/sphinxcontrib-towncrier#92 is resolved. Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Member
|
I had to cherry-pick several commits regarding pre-commit version updates and type-checking fixes. |
nicoddemus
approved these changes
Aug 29, 2024
Member
|
I will not merge myself, would like a second set of eyes to take a look and merge. 👍 |
Pierre-Sassoulas
approved these changes
Aug 29, 2024
Member
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
LGTM, everything is either automated or a cherry-picking it seems (so if the CI is green there's probably no issues with it). Not sure if I we should merge or squash though.
Member
|
In this case I think merging is appropriate, so the cherry-picked commits are preserved. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #12744 as merged into main (c947145).
Fixes #11916 (comment)
Importing
Selffromtypingbreaks the return type on Python 3.9 and under. You should be usingfrom typing_extension import Selfinstead.For example, the following code:
Will error with
Returning Any from function declared to return "CheckdocsItem | None" [no-any-return]on 3.8 & 3.9, but pass on 3.10+ Which can only be worked around by disabling the error entirely in mypy, or doing: