Skip to content

[3.7] bpo-34977: Add Windows App Store package (GH-11027)#11028

Merged
zooba merged 5 commits intopython:3.7from
zooba:bpo34977-3.7
Dec 11, 2018
Merged

[3.7] bpo-34977: Add Windows App Store package (GH-11027)#11028
zooba merged 5 commits intopython:3.7from
zooba:bpo34977-3.7

Conversation

@zooba
Copy link
Member

@zooba zooba commented Dec 7, 2018

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to see the change land on master first, wait until buildbots run, and only later merge into 3.7.

By the way, I prefer "git cherry-pick -x" (from commit in master) to track that it's a backport, but that's just not a requirement :-)

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@zooba
Copy link
Member Author

zooba commented Dec 7, 2018

The backport is slightly different already, so it can't be a direct cherry-pick.

I'll wait for master, but I'm also going to ask @ned-deily to hold 3.7.2rc1 for this change, so please help that one land.

@vstinner
Copy link
Member

vstinner commented Dec 7, 2018

The backport is slightly different already, so it can't be a direct cherry-pick.

Oh ok, I didn't notice.

@ned-deily
Copy link
Member

Since we still have another couple of open issues and this is so close, I am holding 3.7.2rc1 for another day or so in the hopes we can get this in.

@zooba
Copy link
Member Author

zooba commented Dec 10, 2018

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

@zooba zooba merged commit 0e4ad88 into python:3.7 Dec 11, 2018
@zooba zooba deleted the bpo34977-3.7 branch December 11, 2018 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants