gh-59705: Set OS thread name when Thread.name is changed#127702
Merged
vstinner merged 3 commits intopython:mainfrom Dec 10, 2024
Merged
gh-59705: Set OS thread name when Thread.name is changed#127702vstinner merged 3 commits intopython:mainfrom
vstinner merged 3 commits intopython:mainfrom
Conversation
Member
Author
|
@serhiy-storchaka @encukou: I propose to update the OS thread name when The problem is that on macOS, |
serhiy-storchaka
approved these changes
Dec 6, 2024
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM. There are questions for implementation (What about empty name? Is not it dangerous to silently ignore setting the OS name when set name from other thread?), but we can only answer them after users started using this feature.
encukou
reviewed
Dec 10, 2024
Co-authored-by: Petr Viktorin <encukou@gmail.com>
encukou
approved these changes
Dec 10, 2024
Member
Author
|
Merged, thanks for reviews. |
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
…n#127702) Co-authored-by: Petr Viktorin <encukou@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--127702.org.readthedocs.build/