bpo-36778: cp65001 encoding becomes an alias to utf_8#13230
bpo-36778: cp65001 encoding becomes an alias to utf_8#13230vstinner merged 1 commit intopython:masterfrom vstinner:remove_cp65001
Conversation
|
I reproduced #13110 (comment) benchmark: |
|
@methane: Are you ok to simply remove cp65001.py? |
|
I can verify that this change fixes the issue with test_startup_imports I found on Windows IoT Core ARM32 as expected. Also, all test_site and test_codec tests pass on Windows IoT Core with a default codepage of 65001 |
| +-----------------+--------------------------------+--------------------------------+ | ||
| | cp65001 | | Windows only: Windows UTF-8 | | ||
| | | | (``CP_UTF8``) | | ||
| | cp65001 | | Alias to ``utf_8`` encoding | |
There was a problem hiding this comment.
Add the versionchanged directive.
I think it is better to remove this row add add cp65001 to the list of utf-8 aliases.
There was a problem hiding this comment.
I created PR #13240 for your doc change proposal.
|
|
||
| @unittest.skipUnless(sys.platform == 'win32', | ||
| 'cp65001 is a Windows-only codec') | ||
| class CP65001Test(ReadTest, unittest.TestCase): |
There was a problem hiding this comment.
Does utf-8 pass these tests?
There was a problem hiding this comment.
I confirmed utf-8 passes this test.
There was a problem hiding this comment.
Does utf-8 pass these tests?
Sorry, I forgot to specify before I merged my PR that yes: I tested on my Windows 10 and the test still passed. But CP65001Test is now redundant with UTF8Ttest.
I confirmed utf-8 passes this test.
Thanks for checking :-)
|
Shouldn't this comment in class CodePageTest(unittest.TestCase):
# CP_UTF8 is already tested by CP65001Test
CP_UTF8 = 65001 |
Right. I wrote PR #13807 to remove the comment. |
https://bugs.python.org/issue36778