Skip to content

bpo-43631: Update to OpenSSL 1.1.1k#25024

Merged
miss-islington merged 2 commits intopython:masterfrom
tiran:bpo-43631-openssl-1.1.1k
Mar 30, 2021
Merged

bpo-43631: Update to OpenSSL 1.1.1k#25024
miss-islington merged 2 commits intopython:masterfrom
tiran:bpo-43631-openssl-1.1.1k

Conversation

@tiran
Copy link
Member

@tiran tiran commented Mar 26, 2021 •
edited
Loading

  • Build OpenSSL 1.1.1k for macOS
  • Build OpenSSL 1.1.1k for Windows

I have also updated multissl tester and various CI configurations to use latest OpenSSL. The versions were all over the place.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue43631

Automerge-Triggered-By: GH:tiran

@tiran tiran requested review from ned-deily and zooba March 26, 2021 08:20
@tiran
bpo-43631: Update to OpenSSL 1.1.1k
041cd4e 
Signed-off-by: Christian Heimes <christian@python.org>
@tiran tiran force-pushed the bpo-43631-openssl-1.1.1k branch from a9cd05b to 041cd4e Compare March 29, 2021 22:47
@tiran tiran marked this pull request as ready for review March 29, 2021 23:29
@tiran tiran requested review from a team as code owners March 29, 2021 23:29
ned-deily
ned-deily approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only reviewed the macOS build changes and they looked OK with the addition of the tarball checksum update which I just pushed to the PR. Thanks for making the change.

@miss-islington
Copy link
Contributor

miss-islington commented Mar 30, 2021

@tiran: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit a54fc68 into python:master Mar 30, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Mar 30, 2021

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7, 3.8, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Mar 30, 2021

Sorry @tiran, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker a54fc683f237d8f0b6e999a63aa9b8c0a45b7fef 3.9

@miss-islington miss-islington self-assigned this Mar 30, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Mar 30, 2021

Sorry, @tiran, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a54fc683f237d8f0b6e999a63aa9b8c0a45b7fef 3.8

@miss-islington
Copy link
Contributor

miss-islington commented Mar 30, 2021

Sorry @tiran, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker a54fc683f237d8f0b6e999a63aa9b8c0a45b7fef 3.7

@miss-islington
Copy link
Contributor

miss-islington commented Mar 30, 2021

Sorry, @tiran, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a54fc683f237d8f0b6e999a63aa9b8c0a45b7fef 3.6

tiran added a commit to tiran/cpython that referenced this pull request Mar 30, 2021
@tiran
[3.9] bpo-43631: Update to OpenSSL 1.1.1k (pythonGH-25024)
c133e73 
- [x] Build OpenSSL 1.1.1k for macOS
- [x] Build OpenSSL 1.1.1k for Windows

I have also updated multissl tester and various CI configurations to use latest OpenSSL. The versions were all over the place.

Signed-off-by: Christian Heimes <christian@python.org>

Automerge-Triggered-By: GH:tiran.
(cherry picked from commit a54fc68)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot
Copy link

bedevere-bot commented Mar 30, 2021

GH-25088 is a backport of this pull request to the 3.9 branch.

@bedevere-bot
Copy link

bedevere-bot commented Mar 30, 2021

GH-25089 is a backport of this pull request to the 3.8 branch.

tiran added a commit to tiran/cpython that referenced this pull request Mar 30, 2021
@tiran
[3.8] bpo-43631: Update to OpenSSL 1.1.1k (pythonGH-25024)
c2bd785 
- [x] Build OpenSSL 1.1.1k for macOS
- [x] Build OpenSSL 1.1.1k for Windows

I have also updated multissl tester and various CI configurations to use latest OpenSSL. The versions were all over the place.

Signed-off-by: Christian Heimes <christian@python.org>

Automerge-Triggered-By: GH:tiran.
(cherry picked from commit a54fc68)

Co-authored-by: Christian Heimes <christian@python.org>
miss-islington pushed a commit that referenced this pull request Mar 30, 2021
@tiran
[3.8] bpo-43631: Update to OpenSSL 1.1.1k (GH-25024) (GH-25089)
9ac2630 
Signed-off-by: Christian Heimes <christian@python.org>

Automerge-Triggered-By: GH:tiran.
(cherry picked from commit a54fc68)

Co-authored-by: Christian Heimes <christian@python.org>
miss-islington pushed a commit that referenced this pull request Mar 30, 2021
@tiran
[3.9] bpo-43631: Update to OpenSSL 1.1.1k (GH-25024) (GH-25088)
cd82d59 
Signed-off-by: Christian Heimes <christian@python.org>

Automerge-Triggered-By: GH:tiran.
(cherry picked from commit a54fc68)

Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes

@zooba zooba Awaiting requested review from zooba

Assignees

@miss-islington miss-islington

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tiran @miss-islington @bedevere-bot @ned-deily @the-knights-who-say-ni