Verify after signing that identity and provider are as documented#51
Merged
ambv merged 2 commits intopython:masterfrom Jul 26, 2023
Merged
Verify after signing that identity and provider are as documented#51ambv merged 2 commits intopython:masterfrom
ambv merged 2 commits intopython:masterfrom
Conversation
|
All commit authors signed the Contributor License Agreement. |
ambv
reviewed
Jul 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that Sigstore-signed files for releases match the documented identity and providers on the https://python.org/downloads/sigstore page once the values are documented. This PR will solve future issues with signing like the ones that were noted in sigstore/sigstore-python#600.
The only outstanding issue from sigstore/sigstore-python#600 is 3.8 and 3.9 not matching the documented identity. I figure consistency in the short-term with what's happened historically is likely better than something different happening without our knowledge. We will figure out long-term what to do to fix that issue.