Merged
Conversation
rainabba
approved these changes
Sep 22, 2016
Owner
rainabba
left a comment
rainabba
left a comment
There was a problem hiding this comment.
LGTM - Instead of my note, just adding the .\ throughout makes a lot more sense because it will work in all popular shells.
Owner
|
@Trott Very nice. Now how do I cleanup my PR so it will be approved? Should I just edit the commit message and push? Do I need to close my last PR and submit another? |
Author
|
By merging this PR, it updated your PR on the main node repo. So I think you're all set. I just changed my commit review thingy on there to "approved". Hopefully a couple more Windows folks can weigh in and we can get it merged soon... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a PR of what I think is being sought. Does this look right to you? Can you confirm the
.\vcbuildworks in PowerShell? Or does it need to be./vcbuild? Trying to write one command that will work in CMD.exe, PowerShell, and whatever else...