Fix Purge Cache menu caching issue in the front-end#173
Merged
chandrapatel merged 5 commits intortCamp:masterfrom Feb 25, 2019
Merged
Fix Purge Cache menu caching issue in the front-end#173chandrapatel merged 5 commits intortCamp:masterfrom
chandrapatel merged 5 commits intortCamp:masterfrom
Conversation
… value on front-end admin bar. Conditionally display the purge cache button name as 'Purge Cache' for admin dashboard and 'Purge Current Page' on front-end admin bar. Conditionally set query argument 'nginx_helper_urls' value to 'all' for admin dashaboard purge cache button and 'current-url' for front-end admin bar button
Change hook from 'admin_init' to 'admin_bar_init' so that purge_all() is called when purge button is clicked on both admin dashboard and front end admin bar. Check if the user is on front end when set the call purge_url() and purge the current page cache on case basis.
mrrobot47
approved these changes
Feb 21, 2019
Member
mrrobot47
left a comment
mrrobot47
left a comment
There was a problem hiding this comment.
Tested the PR. Working as described in the description.
chandrapatel
suggested changes
Feb 25, 2019
Put the correct value for the 'meta key' of add_menu() and remove escaping from purge_url() on line 688 as already escaped at the end
chandrapatel
approved these changes
Feb 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have fixed the Purge Cache menu caching issue in front-end.
I have changed the name of Purge Cache menu button in the front to 'Purge Current Page'
When the 'Purge Current Page' menu button on the front end is now clicked, it only clears the page cache.
Fixes #171