optimize places_conflict to avoid complex vectors etc#51849
optimize places_conflict to avoid complex vectors etc#51849bors merged 5 commits intorust-lang:masterfrom
places_conflict to avoid complex vectors etc#51849Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors try |
|
⌛ Trying commit e10414e with merge c2d26676c063f01d952f57ba7667a1d130040fe6... |
This micro-optimizes some if checks away; the compiler may already have been doing it, not sure.
|
@Mark-Simulacrum did you ever do a perf run here? I did a few further edits...but it'd be interesting to see a run with the first set of commits. |
|
Not yet I think, let's start another one with the latest set though too. @bors try |
optimize `places_conflict` to avoid complex vectors etc Fixes #51820 I've not measured the perf here, we should.
|
☀️ Test successful - status-travis |
|
Links for when perf is done: |
|
r? @eddyb -- the first run already shows this is having a pretty good effect, actually. |
|
@bors r+ |
|
📌 Commit 5c06b23 has been approved by |
|
@bors r=eddyb |
|
📌 Commit cb34989 has been approved by |
|
Second run is also ready. |
|
⌛ Testing commit cb34989 with merge 409fb98770f31401ff4d3811ab8a41c60f5f8591... |
|
💔 Test failed - status-appveyor |
|
@bors retry |
|
⌛ Testing commit cb34989 with merge 6f6943c92a7855b1343bb094b0c6bc59d81eaffc... |
|
💔 Test failed - status-travis |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
1 similar comment
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors retry |
|
@bors p=40 |
optimize `places_conflict` to avoid complex vectors etc Fixes #51820
|
☀️ Test successful - status-appveyor, status-travis |
Fixes #51820