Mark asm tests as requiring LLVM 10.0.1#83485
Conversation
|
(rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
|
Inline asm requires LLVM 10.0.1 but the Ubuntu package is only 10.0.0. Unfortunate. |
|
I've added proper LLVM version annotations to the tests so they should be enabled automatically when we do the next LLVM version bump. |
|
@bors r+ |
|
📌 Commit 62e7331 has been approved by |
Mark asm tests as requiring LLVM 10.0.1
Rollup of 8 pull requests Successful merges: - rust-lang#83055 ([rustdoc] Don't document stripped items in JSON renderer.) - rust-lang#83437 (Refactor rust-lang#82270 as lint instead of an error) - rust-lang#83444 (Fix bootstrap tests on beta) - rust-lang#83456 (Add docs for Vec::from functions) - rust-lang#83463 (ExitStatusExt: Fix missing word in two docs messages) - rust-lang#83470 (Fix patch note about rust-lang#80653 not mentioning nested nor recursive) - rust-lang#83485 (Mark asm tests as requiring LLVM 10.0.1) - rust-lang#83486 (Don't ICE when using `#[global_alloc]` on a non-item statement) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
Should |
|
Oh yea that's definitely a mistake. Rust's LLVM has a custom patch to recognize |
fix: alloc-optimisation is only for rust llvm As discussed at the bottom of rust-lang#83485. On a separate note I'll take this chance ask, is it worth pulling in that patch (to recognise `__rust_dealloc`) into Debian's system LLVM? The main factors for us to consider would be (1) is the optimisation significant and (2) is there not any significant negative impact to non-rust packages that use LLVM.
No description provided.