-Add ldap search filter to settings#102
Merged
figureone merged 1 commit intouhm-coe:masterfrom Sep 24, 2021
Merged
Conversation
Member
|
Looks great! We'll review and merge it in for the upcoming release. Thanks for contributing! |
figureone
approved these changes
Sep 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this branch, I added the setting ldap_search_filter to the code and admin page. I made the changes based off the WP plugin that is downloaded from the WP website, and it works. I re-implemented the changes here, and did not fully test, but they are pretty minor copy and paste.