Fix incorrect image sizes in media image-size command#192
Merged
schlessera merged 3 commits intowp-cli:mainfrom Mar 14, 2024
ernilambar:116-fix-image-size
Merged
Fix incorrect image sizes in media image-size command#192schlessera merged 3 commits intowp-cli:mainfrom ernilambar:116-fix-image-size
media image-size command#192schlessera merged 3 commits intowp-cli:mainfrom
ernilambar:116-fix-image-size
Conversation
Member
|
Can we add a test verifying this behavior? Should be possible to add & activate a small plugin that registers additional image sizes, then run the command. |
Member
Author
|
@swissspidy Can you please run Behat test manually in GitHub action? |
Member
|
Oh, looks like the workflow was disabled due to inactivity |
Member
Author
schlessera
approved these changes
Mar 14, 2024
schlessera
added
the
command:media-image-size
Member
|
Thanks, @ernilambar ! |
schlessera
changed the title
media image-size command
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #116
wp_get_registered_image_subsizes()for fetching image size information