Removed unused $new_assoc_args variable in wp rewrite structure subcommand#73
Merged
swissspidy merged 3 commits intowp-cli:mainfrom May 23, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Contributor
|
@viralsampat90 Please see https://github.com/wp-cli/rewrite-command/pull/73/files for automated phpcs comments. |
swissspidy
reviewed
May 22, 2025
Member
|
@viralsampat90 |
Contributor
|
Hello @ernilambar, Thank you very much for your valuable feedback. I have reviewed my pull request, implemented the suggested changes, and have resubmitted it for your review. Thanks, |
ernilambar
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Team,
I have reviewed issue #40: Remove unused variable $new_assoc_args in wp rewrite structure subcommand.
After analyzing the code, I found the variable is indeed unused. I have implemented a fix by removing the unused variable from the relevant file.
A pull request has been created with this change.
Thank you!