Fix incorrect interaction between object_storage_remote_initiator and object_storage_cluster.

[ianton-ru]

Changelog category (leave one):

• Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix incorrect interaction between object_storage_remote_initiator and object_storage_cluster.

Documentation entry for user-facing changes

Fix issues from #1640 (comment)

CI/CD Options

Exclude tests:

• Fast test
• Integration Tests
• Stateless tests
• Stateful tests
• Performance tests
• All with ASAN
• All with TSAN
• All with MSAN
• All with UBSAN
• All with Coverage
• All with Aarch64
• All Regression
• Disable CI Cache

Regression jobs to run:

• Fast suites (mostly <1h)
• Aggregate Functions (2h)
• Alter (1.5h)
• Benchmark (30m)
• ClickHouse Keeper (1h)
• Iceberg (2h)
• LDAP (1h)
• Parquet (1.5h)
• RBAC (1.5h)
• SSL Server (1h)
• S3 (2h)
• S3 Export (2h)
• Swarms (30m)
• Tiered Storage (2h)

[github-actions]

Workflow [PR], commit [eb71a12]

[ianton-ru]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[ilejn]

Please, describe the exact defect that this PR fixes.

[alsugiliazova]

Verification: PR #1783

PR-added tests — all GREEN

2 tests × 3 integration jobs = 6 OK runs, 0 failures.

Job	New tests	Status
Integration tests (amd_asan, db disk, old analyzer, 4/6)	2	OK
Integration tests (amd_binary, 5/5)	2	OK
Integration tests (arm_binary, distributed plan, 2/4)	2	OK

Coverage:

• The “remote initiator after a plain (non-remote) query” regression scenario passes everywhere.
• The new analyzer-guard NOT_IMPLEMENTED error path is exercised everywhere.

CI overview (head commit)

• PR test workflow: 43 success / 50 skipped / 3 failure
• Regression workflow: 29 success / 67 skipped / 4 failure (chronic baseline)

PR test-workflow failures

Check	Verdict
Stateless tests (arm_asan, azure, sequential, 2/2) — 03443_shared_storage_snapshots	Pre-existing flake (33 fails / 20 PRs in 30d). Unrelated.
Stress test (amd_release) — Cannot start clickhouse-server	Pre-existing stress infra flake (33 fails / 14 PRs in 30d). Server fails to come up during stress harness; not a product-level test. Unrelated to the diff.
Stress test (arm_asan) — Cannot start clickhouse-server	Same as above.

The PR diff is in cluster-side query rewriting; none of these failure paths touch that code.

Regression-workflow failures (chronic baseline on antalya-26.3)

Suite	Fails
Swarms (Aarch64 + Release)	227
Parquet (Aarch64 + Release)	34
S3Export partition (Aarch64 + Release)	20
S3Export part (Aarch64 + Release)	18

Same fingerprint as sibling antalya-26.3 PRs (1775, 1773, 1772, 1771, 1770, 1769, …). No new failure modes.

Caveat — partial frontport

This PR lands on antalya-26.3 while companion features from antalya-26.1 are still being frontported in parallel. Final re-verify recommended once the rest of the bundle lands.

Verdict

Safe to merge.

[alsugiliazova]

Audit: PR #1783 — Fix incorrect interaction between object_storage_remote_initiator and object_storage_cluster

AI audit note: generated by AI (Cursor agent, audit-review skill). Follow-up to the prior audit of PR #1640 (tmp/audit-pr1640.md).

Findings vs. prior #1640 audit

Prior #1640 finding	Severity	Status in #1783
cluster_name_in_settings persistent stale state corrupts subsequent queries	High	Fixed (commit 02baf4a)
Null deref of query_tree on remote-initiator + join_mode=local + analyzer=0	Medium	Fixed (commit eb71a12)
engine_to_function / function_to_cluster_function map mismatch	Low	Not in scope of this PR; invalid

New defects introduced by this PR

None.

Test coverage

• test_remote_initiator_after_non_remote — direct regression test for the High finding (asserts a non-cluster query after a cluster query no longer dispatches as a cluster query).
• test_remote_initiator_after_with_join_old_analyzer — direct regression test for the Medium finding (asserts NOT_IMPLEMENTED instead of null deref).

Verdict

Both prior defects are fixed and covered by new integration tests. Safe to merge.