Cherry-pick: Backport #85440 to 24.8: Fix possible UB in case of MEMORY_LIMIT_EXCEEDED during String deserialization - #2088
Merged
Conversation
Backport ClickHouse#85440 to 24.8: Fix possible UB in case of MEMORY_LIMIT_EXCEEDED during String deserialization
Collaborator
|
This is an automated comment for commit dd86c51 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
Member
Author
Collaborator
CI triage — 1 real failure, and it's not a code/test problemVerdict: 2 red checks, both trace to the same root cause. 0 test/build failures, 1 process failure (DCO), and the
DCO (the only substantive failure)The cncf/dco2 app reports:
The single commit on this branch ( Suggested fix (needs a history rewrite of the head commit, so it's yours to run — I don't force-push): git checkout releasy/port/pr-85692-3718c4
git commit --amend --signoff
git push --force-with-lease origin releasy/port/pr-85692-3718c4Alternatively, cncf/dco2 accepts a remediation commit (a non-rewrite option) if you'd rather not force-push — see the "add remediation commit" link in the DCO check output. If you want, tell me to open it as a separate
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from ClickHouse#85692.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix possible UB (crashes) in case of MEMORY_LIMIT_EXCEEDED during String deserialization (ClickHouse#85440 by @azat)
CI/CD Options
Exclude tests:
Regression jobs to run: