You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request makes a minor update to the ProtocolDefinitionItem class in the DevTools generator, primarily affecting JSON serialization behavior for the description property.
Serialization improvements:
Marked the Description property with [JsonIgnore] to prevent it from being included in JSON serialization, ensuring only the internal InitialDescription is serialized.
Added [JsonInclude] to the InitialDescription property to explicitly allow its serialization, supporting correct deserialization and serialization of the description field.
Ensure XML documentation is generated/published for .NET DevTools types (e.g., OpenQA.Selenium.DevTools.V143.Accessibility.AXNode) so the API docs pages are not missing member/type docs.
Codebase Duplication Compliance
⚪
Codebase context is not defined
Follow the guide to enable codebase context checks.
Custom Compliance
🟢
Generic: Comprehensive Audit Trails
Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance.
Fix a potential NullReferenceException and incomplete XML escaping in the Description property's getter by using System.Security.SecurityElement.Escape().
public string? Description
{
- get => InitialDescription?.Replace("<", "<").Replace(">", ">");+ get => System.Security.SecurityElement.Escape(InitialDescription);
set => InitialDescription = value;
}
Apply / Chat
Suggestion importance[1-10]: 9
__
Why: The suggestion correctly identifies a critical NullReferenceException bug and also points out the incomplete XML escaping, proposing a robust fix using a standard library method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor update to the
ProtocolDefinitionItemclass in the DevTools generator, primarily affecting JSON serialization behavior for thedescriptionproperty.Serialization improvements:
Descriptionproperty with[JsonIgnore]to prevent it from being included in JSON serialization, ensuring only the internalInitialDescriptionis serialized.[JsonInclude]to theInitialDescriptionproperty to explicitly allow its serialization, supporting correct deserialization and serialization of the description field.🔗 Related Issues
Fixes #16715
💥 What does this PR do?
🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes